chris/harbour-sailfin
chris/harbour-sailfin
1
0
Fork 0
mirror of https://github.com/HenkKalkwater/harbour-sailfin.git synced 2025-09-01 08:52:45 +00:00
Code Issues Releases Wiki Activity

Replace not-fully-initializing DTO constructors

Browse source 
There were some constructors in the DTOs which allowed construction of
DTO which weren't fully initialized. These constructors have been made
private, as they are still used in the 'fromJson' methods. Additionally,
a constructor with all required parameters to fully initialize the
class has been added.

Additionally, the Loader class has been modified, since it no longer can
assume it is able to default construct the parameter type. The parameter
is now stored as an optional.

Closes #15
This commit is contained in:
Chris Josten 2021-09-25 16:54:33 +02:00
parent 1e795ae8b6
commit 90db983c30
358 changed files with 3785 additions and 322 deletions
Download patch file Download diff file Expand all files Collapse all files

13
core/include/JellyfinQt/dto/bufferrequestdto.h
View file

@ -48,7 +48,13 @@ namespace DTO {
class BufferRequestDto {
public:
BufferRequestDto();
BufferRequestDto(
QDateTime when,
qint64 positionTicks,
bool isPlaying,
QString playlistItemId
);
BufferRequestDto(const BufferRequestDto &other);
/**
@ -103,8 +109,13 @@ protected:
qint64 m_positionTicks;
bool m_isPlaying;
QString m_playlistItemId;
private:
// Private constructor which generates an invalid object, for use withing BufferRequestDto::fromJson();
BufferRequestDto();
};
} // NS DTO
namespace Support {