chris/harbour-sailfin
chris/harbour-sailfin
1
0
Fork 0
mirror of https://github.com/HenkKalkwater/harbour-sailfin.git synced 2025-09-05 10:12:46 +00:00
Code Issues Releases Wiki Activity

Restructured the way item "details" are loaded

Browse source 
Previously, Items were displayed in one page, named DetailPage.qml.
This page then would load a qml component, based on the page type. It
also contained some components common for each detail page, like
displaying the name of the item. This construction had as downside that
modifying the page properties, adding a pulley menu or basing the page
around a SilicaListview was not possible. So I already had created some
other pages.

The new construction uses a base page, named BaseDetailPage which does
set some common properties and handle the loading of the items, so that
that part does not have to be duplicated. Displaying the name of an item
was a very trivial thing to do, so duplicating that part across files
was not a problem. Anyway, the rest of the pages are now seperate, but
all have BaseDetailsPage as the root, so they can use the common
functionality by that page. Those subpages now can be based around
GridViews, Carrousels, have pully menus and so on. To determine to which
page to go to, based on the content type, a function named getPageUrl
has been added to Utils.js, which takes a content type as argument and
gives the page url back.
This commit is contained in:
Chris Josten 2020-09-29 02:15:50 +02:00
parent fedae0b912
commit b68da318f2
21 changed files with 509 additions and 525 deletions
Download patch file Download diff file Expand all files Collapse all files

21
translations/harbour-sailfin.ts
View file

@ -102,14 +102,7 @@
</message>
</context>
<context>
<name>DetailPage</name>
<message>
<source>Loading</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>EpisodeDetails</name>
<name>EpisodePage</name>
<message>
<source>Episode %1–%2 Season %3</source>
<translation type="unfinished"></translation>
@ -120,7 +113,7 @@
</message>
</context>
<context>
<name>FilmDetails</name>
<name>FilmPage</name>
<message>
<source>Released: %1 — Run time: %2</source>
<translation type="unfinished"></translation>
@ -205,7 +198,7 @@
</message>
</context>
<context>
<name>SeasonDetails</name>
<name>SeasonPage</name>
<message>
<source>No overview available</source>
<extracomment>No overview/summary text of an episode available</extracomment>
@ -213,7 +206,7 @@
</message>
</context>
<context>
<name>SeriesDetails</name>
<name>SeriesPage</name>
<message>
<source>Seasons</source>
<extracomment>Seasons of a (TV) show</extracomment>
@ -258,13 +251,13 @@
</message>
</context>
<context>
<name>UnsupportedDetails</name>
<name>UnsupportedPage</name>
<message>
<source>This is still an alpha version :)</source>
<source>Item type (%1) unsupported</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Item type (%1) unsupported</source>
<source>This is still an alpha version :)</source>
<translation type="unfinished"></translation>
</message>
</context>