From f9e85618c84838f4b5bbda0a95760eac517f23e6 Mon Sep 17 00:00:00 2001
From: Jonas Herzig <me@johni0702.de>
Date: Tue, 5 Feb 2019 13:48:14 +0100
Subject: [PATCH] Make port in --server argument optional

---
 src/main.rs | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/src/main.rs b/src/main.rs
index cf7a722..c9b90d0 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -66,7 +66,7 @@ fn main() {
             .add_option(
                 &["--server"],
                 Store,
-                "Hostname and port of upstream mumble server",
+                "Hostname and (optionally) port of the upstream Mumble server",
             )
             .required();
         ap.refer(&mut accept_invalid_certs).add_option(
@@ -78,13 +78,19 @@ fn main() {
         ap.parse_args_or_exit();
     }
 
-    let mut upstream_parts = upstream.rsplitn(2, ':');
-    let upstream_port: u16 = upstream_parts
-        .next()
-        .expect("Missing upstream port")
-        .parse()
-        .expect("Failed to parse upstream port");
-    let upstream_host = upstream_parts.next().expect("Missing upstream host name");
+    // Try parsing as raw IPv6 address first
+    let (upstream_host, upstream_port) = match upstream.parse::<Ipv6Addr>() {
+        Ok(_) => (upstream.as_ref(), 64738),
+        Err(_) => {
+            // Otherwise split off port from end
+            let mut upstream_parts = upstream.rsplitn(2, ':');
+            let right = upstream_parts.next().expect("Empty upstream address");
+            match upstream_parts.next() {
+                Some(host) => (host, right.parse().expect("Failed to parse upstream port")),
+                None => (right, 64738),
+            }
+        }
+    };
     let upstream_host = Box::leak(Box::new(upstream_host.to_owned())).as_str();
     let upstream_addr = (upstream_host, upstream_port)
         .to_socket_addrs()