debian-packages/eventcore
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Avoid interference with other users of waitpid.

Browse source 
Instead of using waitpid(-1), explicitly waits on all known processes. This is inefficient for large numbers of child processes, but seems to be the only way to ensure to not interfere with other code that uses waitpid().
This commit is contained in:
Sönke Ludwig 2019-08-21 23:24:02 +02:00 committed by Sönke Ludwig
parent 72234fc0a7
commit 4724f14145
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
source/eventcore/drivers/posix/processes.d
View file

@ -273,12 +273,18 @@ final class SignalEventDriverProcesses(Loop : PosixEventLoop) : EventDriverProce
} }
// instead, use waitpid to determine all exited processes // instead, use waitpid to determine all exited processes
while (true) { ProcessID[] allprocs;
int status; () @trusted {
auto ret = () @trusted { return waitpid(-1, &status, WNOHANG); } (); try synchronized (StaticProcesses.m_mutex)
if (ret <= 0) break; allprocs = StaticProcesses.m_processes.keys;
catch (Exception e) assert(false, e.msg);
} ();
onProcessExit(ret, () @trusted { return WEXITSTATUS(status); } ()); foreach (pid; allprocs) {
int status;
auto ret = () @trusted { return waitpid(cast(int)pid, &status, WNOHANG); } ();
if (ret == cast(int)pid)
onProcessExit(ret, () @trusted { return WEXITSTATUS(status); } ());
} }
} }