debian-packages/eventcore
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix out of order processing issue with the TCP connection callback.

Browse source 
It could happen that the socket FD got reused before the connection callback was cleared. This in turn could result in the new connection callback to get overwritten with null.
This commit is contained in:
Sönke Ludwig 2017-01-30 10:54:43 +01:00
parent 4703f021ec
commit 956978cc79
No known key found for this signature in database
GPG key ID: D95E8DB493EE314C
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
source/eventcore/drivers/posix/sockets.d
View file

@ -43,6 +43,8 @@ final class PosixEventDriverSockets(Loop : PosixEventLoop) : EventDriverSockets
final override StreamSocketFD connectStream(scope Address address, scope Address bind_address, ConnectCallback on_connect) final override StreamSocketFD connectStream(scope Address address, scope Address bind_address, ConnectCallback on_connect)
{ {
assert(on_connect !is null);
auto sockfd = createSocket(address.addressFamily, SOCK_STREAM); auto sockfd = createSocket(address.addressFamily, SOCK_STREAM);
if (sockfd == -1) return StreamSocketFD.invalid; if (sockfd == -1) return StreamSocketFD.invalid;
@ -105,8 +107,10 @@ final class PosixEventDriverSockets(Loop : PosixEventLoop) : EventDriverSockets
m_loop.setNotifyCallback!(EventType.write)(sock, null); m_loop.setNotifyCallback!(EventType.write)(sock, null);
with (m_loop.m_fds[sock].streamSocket) { with (m_loop.m_fds[sock].streamSocket) {
state = ConnectionState.connected; state = ConnectionState.connected;
connectCallback(cast(StreamSocketFD)sock, ConnectStatus.connected); assert(connectCallback !is null);
auto cb = connectCallback;
connectCallback = null; connectCallback = null;
cb(cast(StreamSocketFD)sock, ConnectStatus.connected);
} }
} }