debian-packages/eventcore
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add proper thread synchronization to EventDriverDNS_GAI.

Browse source
This commit is contained in:
Sönke Ludwig 2019-10-07 11:18:58 +02:00
parent 5255645455
commit b77adfcbd2
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
source/eventcore/drivers/posix/dns.d
View file

@ -28,11 +28,12 @@ version (Posix)
final class EventDriverDNS_GAI(Events : EventDriverEvents, Signals : EventDriverSignals) : EventDriverDNS { final class EventDriverDNS_GAI(Events : EventDriverEvents, Signals : EventDriverSignals) : EventDriverDNS {
import std.parallelism : task, taskPool; import std.parallelism : task, taskPool;
import std.string : toStringz; import std.string : toStringz;
import core.atomic : atomicFence, atomicLoad, atomicStore;
import core.thread : Thread; import core.thread : Thread;
private { private {
static struct Lookup { static struct Lookup {
bool done; shared(bool) done;
DNSLookupCallback callback; DNSLookupCallback callback;
addrinfo* result; addrinfo* result;
int retcode; int retcode;
@ -104,7 +105,8 @@ final class EventDriverDNS_GAI(Events : EventDriverEvents, Signals : EventDriver
if (m_lookup.retcode == -1) if (m_lookup.retcode == -1)
version (CRuntime_Glibc) version (linux) __res_init(); version (CRuntime_Glibc) version (linux) __res_init();
m_lookup.done = true; atomicStore(m_lookup.done, true);
atomicFence(); // synchronize the other fields in m_lookup with the main thread
m_events.trigger(m_event, true); m_events.trigger(m_event, true);
debug (EventCoreLogDNS) print("lookup %s finished", m_lookup.name); debug (EventCoreLogDNS) print("lookup %s finished", m_lookup.name);
} }
@ -131,10 +133,13 @@ final class EventDriverDNS_GAI(Events : EventDriverEvents, Signals : EventDriver
{ {
debug (EventCoreLogDNS) print("DNS event triggered"); debug (EventCoreLogDNS) print("DNS event triggered");
m_events.wait(m_event, &onDNSSignal); m_events.wait(m_event, &onDNSSignal);
size_t lastmax; size_t lastmax;
foreach (i, ref l; m_lookups) { foreach (i, ref l; m_lookups) {
if (i > m_maxHandle) break; if (i > m_maxHandle) break;
if (!l.done) continue; if (!atomicLoad(l.done)) continue;
// synchronize the other fields in m_lookup with the lookup thread
atomicFence();
try { try {
l.thread.join(); l.thread.join();