Commit graph

128 commits

Author SHA1 Message Date
Sönke Ludwig
496e99c3b4 Make the API robust against using invalid handles. Fixes #105.
Introduces a "validationCounter" field for all handle types that gets incremented (at least) whenever an OS file descriptor/handle gets invalidated or re-allocated. This way, an old eventcore handle to a reused OS handle can always be distinguished from the current one to avoid interference.
2020-05-11 17:05:53 +02:00
Sönke Ludwig
768c6cf4c8
Merge pull request #143 from Geod24/deprecations
Fix a printf format deprecation triggered by 2.092
2020-05-11 17:03:01 +02:00
Geod24
3888f9f6a0 Fix a printf format deprecation triggered by 2.092 2020-05-11 11:14:03 +09:00
Hiroki Noda
e6660486a3 Set close-on-exec flag for PipeFD 2020-04-09 21:36:19 +09:00
Sönke Ludwig
8597d2ae34 Add missing ESHUTDOWN constant for macOS. 2020-03-18 07:59:41 +01:00
Sönke Ludwig
7c3fdc5ddf Fix possible hang after partial socket reads. 2020-03-17 15:15:19 +01:00
Sönke Ludwig
3b44da604c Handle disconnects during socket read/write.
The connection state was not updated anymore since the changes in b32b329d15.

This fixes CI errors in vibe.d
2020-03-17 14:22:44 +01:00
Sönke Ludwig
215735f48f Use MonoTime for timers. 2020-03-15 21:29:27 +01:00
Sönke Ludwig
b32b329d15 Fix the approach to determine connect failures.
On macOS it could happen that both, onConnect and onConnectError, were triggered, resulting in seemingly overlapping connection attempts when they really were sequential. This in turn triggered a connection error leak test in vibe-core.

Now using only the write-ready flag plus the reported socket error status to determine failed connections, guaranteeing a single call back.
2020-03-15 18:49:54 +01:00
Hiroki Noda
3fd907edd4 Remove unused function: min 2020-01-10 14:17:24 +09:00
Sönke Ludwig
14a896be5d Attempt to fix crash in thread based DNS lookup.
Depending on the timing of starting and finishing DNS queries, `Thread.join` could be called on an instance that had already been `destroy`ed. To avoid this, the thread instance is now explicitly set to null, as well as resetting the "done" field to avoid redundant work for unused slots.

See vibe-d/vibe.d#2378.
2019-10-25 09:27:22 +02:00
The Dlang Bot
38536e0be9
Merge pull request #126 from Geod24/suppert
Update list of compilers to match vibe-core
merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com>
2019-10-08 21:25:41 +02:00
Sönke Ludwig
b77adfcbd2 Add proper thread synchronization to EventDriverDNS_GAI. 2019-10-07 11:18:58 +02:00
Sönke Ludwig
5255645455 Start a thread for each DNS lookup. Fixes vibe-d/vibe.d#2378.
std.parallelism.Task.executeInNewThread leaks the thread's resources instead of reusing it in later calls. As a workaround, this commit starts a new thread for every lookup and properly tears it down afterwards. At a later point, this code should be changed to reuse the thread(s), if possible, to avoid the startup overhead.
2019-10-07 11:10:21 +02:00
Benjamin Schaaf
782fc40152 Add MSG_NOSIGNAL flag to send call to avoid SIGPIPE (#128)
Add MSG_NOSIGNAL flag to send call to avoid SIGPIPE
merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com>
2019-09-06 19:15:30 +02:00
Geod24
312f49ce65 Remove outdate comments for unsupported compilers 2019-09-03 02:10:02 +09:00
Sönke Ludwig
20373d10db Fix indentation and remove unused imports/variables. 2019-08-23 19:55:55 +02:00
Sönke Ludwig
5c3afcc175 Ensure that a valid PID is passed to kill(). 2019-08-23 09:35:13 +02:00
Sönke Ludwig
01c2c26964 Fix Windows compilation.
Integrates the contents of StaticProcesses into PosixEventDriverProcesses to fully hide it form the Windows build. It also changes lockedProcessInfo to be a non-template function, as that lead to a linker error on macOS.
2019-08-23 09:35:13 +02:00
Sönke Ludwig
f1c2eb779f Use the Posix process driver on all Posix operating systems. 2019-08-23 09:35:13 +02:00
Sönke Ludwig
7ebad49ed0 Rework the child process exit code to not rely in SIGCHLD.
It turns out that in a heterogeneous process where other parts of the code may start processes or threads and may be waiting for those to finish, it is not realistic to rely on signalfd or even SIGCHLD in general to get notified about child process exits. The only solid way appears to be to start a separate waiter thread that uses waitid/waitpid to wait for exited child processes in a blocking way.

This also fixes the hanging vibe.core.process test in vibe-core with DMD 2.087.x.
2019-08-23 09:35:12 +02:00
Sönke Ludwig
4724f14145 Avoid interference with other users of waitpid.
Instead of using waitpid(-1), explicitly waits on all known processes. This is inefficient for large numbers of child processes, but seems to be the only way to ensure to not interfere with other code that uses waitpid().
2019-08-23 09:35:12 +02:00
Sönke Ludwig
72234fc0a7 Return an invalid wait ID for processes.wait() if the process has already exited.
Avoids overlap with valid wait IDs, so that a paired cancelWait() doesn't cancel a different wait.
2019-08-23 09:35:12 +02:00
Sönke Ludwig
507fb5a0c9 Use waitpid to iterate over all exited child processes. Fixes #116. Closes #117. 2019-08-23 09:35:12 +02:00
Sönke Ludwig
e1c6d99798 Fix indentation style. 2019-08-23 09:35:11 +02:00
Caleb Connolly
c2e55122bf
Fix #119
Added missing import to fix `undefined identifier intptr_t`
2019-08-20 17:43:25 +00:00
Sönke Ludwig
9bb6be87c3 Fix possible access of freed directory watcher entries.
This mainly affected macOS, which currently uses the polling directory watcher. Since entries were freed during the loop, the remaining keys could point to already freed entries.
2019-08-19 23:59:11 +02:00
Sönke Ludwig
cf33c3d859
Merge pull request #112 from BenjaminSchaaf/socket-fix
Fix socket not being in a connected state after connectStream
2019-08-17 14:44:48 +02:00
Benjamin Schaaf
4d71b62507 Fix crash when subprocess was not spawned by eventcore 2019-07-22 10:55:45 +10:00
Benjamin Schaaf
a8cd897df7 Proposed fix for processes in multi-threaded environments 2019-07-21 20:43:06 +10:00
Benjamin Schaaf
472321f1f5 Fix socket not being in a connected state after connectStream 2019-07-17 23:12:59 +10:00
Sönke Ludwig
e7bf50ea2d
Merge pull request #110 from BenjaminSchaaf/process
Fix pipe writing
2019-06-02 09:13:26 +02:00
Sönke Ludwig
731936ce9e Separate the polling logic of PollEventDriverWatchers into a separate class.
Allows to keep thread-local state separate from the mutex-protected/immutable state in PollingThread to make sure that there are no unwanted accesses.
2019-05-30 11:33:04 +02:00
Benjamin Schaaf
9a09e42802 Fix pipe writing 2019-05-05 14:31:12 +10:00
Sönke Ludwig
48d083b20f Fix possible race condition in PosixEventDriverEvents.trigger.
Accessing the event slot should only be done from the owner thread, since the chunk index of the ChoppedVector could be updated at any time. Instead of a triggerAll field, this flag is now propagated through the underlying eventfd/socket pair.
2019-04-13 18:27:23 +02:00
Leonid Kramer
1bbe244196
Merge pull request #107 from vibe-d/disable_so_addr
Add `StreamListenOptions.reuseAddress`.
2019-04-01 20:38:29 +02:00
The Dlang Bot
b11936e4bc
Merge pull request #100 from BenjaminSchaaf/process
Add APIs for working with Subprocesses and Pipes
merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com>
2019-04-01 14:48:41 +02:00
Sönke Ludwig
891eed3d62 Add StreamListenOptions.reuseAddress and make it the default.
Replaces the current combined behavior controlled by `reusePort`, introduced by #103.
2019-04-01 13:50:33 +02:00
Radu Racariu
11ad96be4d
Import the druntime core.sys.posix.sys.socket
This will pickup platform specific definitions from the
2019-03-14 16:29:02 +02:00
Sönke Ludwig
5f703cf039
Merge pull request #104 from rracariu/patch-1
[PosixEventDriverEvents] Use Linux definitions from druntime
2019-02-23 14:04:37 +01:00
Benjamin Schaaf
1afc5ca1c0 Fix waiterCount not including waiting processes 2019-02-21 22:13:05 +11:00
Radu Racariu
07b09e8692
fix @safe 2019-02-12 19:55:32 +02:00
Radu Racariu
6286c7980d
[PosixEventDriverEvents] Use Linux definitions from druntime
This doesn't duplicate the definitions form `core.sys.linux.sys.eventfd` and will pickup any platform specifics for better portability.
Fixes https://github.com/vibe-d/eventcore/issues/102
2019-02-12 19:47:37 +02:00
Radu Racariu
cb06ecfbcf
don't try to set the SO_REUSEPORT flag
On Linux this option was always set, regardless if the `StreamListenOptions` specifies it.

On some systems setting that option will result in a failure.
2019-02-11 15:42:42 +02:00
Benjamin Schaaf
7ef5c6686e Fix more Windows compiler errors 2019-01-16 10:23:25 +11:00
Benjamin Schaaf
dd915e74b1 Fix Windows compiler errors 2019-01-16 10:09:49 +11:00
Benjamin Schaaf
6108a64973 Fix OSX compiler errors 2019-01-15 21:32:36 +11:00
Benjamin Schaaf
7d091ed504 Add APIs for working with Subprocesses and Pipes with an implementation for Posix 2019-01-15 19:58:01 +11:00
Hiroki Noda
3b6b2ab900 Use monotonic clock for timeout
The system clock can be updated manually by the sys-admin or
automatically by NTP, so use monotonic clock instead.
2018-12-23 21:37:12 +09:00
Sönke Ludwig
968084f074 Remove the default dependency to libanl. Fixes #78.
The dependency wasn't used at all, but is now optionally used through the epoll-gaia configuration.
2018-11-11 13:07:48 +01:00