Sönke Ludwig
0e1d74cc41
Call Windows IO callbacks outside of completion routines.
...
Calling WinSock functions from inside of a completion routine results in undefined behavior, because the completion routine may be triggered within another WinSock function that enters an alertable wait state. For this reason, none of the callbacks that are triggered by overlapped I/O may be invoked directly from a completion routine.
To solve this, a ConsumableQueue is filled with all completion events that occur and is processed after each MsgWaitForMultipleObjectsEx call.
2018-03-10 22:59:21 +01:00
Sönke Ludwig
0b02c84b2b
Set ConnectionState.connected when accepting a connection. Fixes #54 .
2018-03-07 11:00:03 +01:00
Sönke Ludwig
008163e913
Fix setTCPNoDelay/setKeepAlive and add assertions.
...
Assertions make sure that socket query functions are not called with an invalid handle (resulting in strange out-of-memory errors).
2018-03-07 10:52:01 +01:00
Sönke Ludwig
43ef41d4fa
Fix deprecation warning on DMD 2.079.0.
2018-03-06 20:09:03 +01:00
Sönke Ludwig
3d2a2656bb
Robustness fix for WinAPIEventDriverWatchers.
...
Under certain (rare) circumstances, the receive buffer contains data from a file instead of the expected FILE_NOTIFY_INFORMATION structure. No signs of handle or buffer reuse could be found, so the cause for this remains unclear. Until the cause can be narrowed down, this keeps the issue visible while avoiding to crash the application.
2018-03-03 20:04:51 +01:00
Sönke Ludwig
fbd6927377
Improve robustness of file I/O callbacks for the WinAPI driver.
...
Explicitly gets the read/write slot from the handle map from within the callback instead of dereferencing the pointer assigned when starting the operation. This makes sure that no dangling reference is accessed. Instead, if the slot got reused before the callback is invoked (which is a bug), an assertion will be triggered if the slot now has a different handle type.
2018-03-03 19:56:54 +01:00
Sönke Ludwig
3a52e0f362
Fix cast from HANDLE to descriptor in the WinAPI driver.
...
Avoids truncation to 32-bit for 64-bit builds. Also improves robustness of the directory watcher shutdown procedure.
2018-03-03 19:56:54 +01:00
Sönke Ludwig
e8e8f85271
Add DatagramSocket.broadcast property. Fixes #47 .
2018-02-22 02:08:09 +01:00
Sönke Ludwig
b2b072dd80
Reduce the number of ChoppedVector index operations.
2018-02-22 01:58:49 +01:00
Sönke Ludwig
30f614a7ff
Merge pull request #50 from vibe-d/fix_watcher_cancellation
...
Fix watcher cancellation
2018-02-22 01:56:13 +01:00
Sönke Ludwig
0e7091d085
Fix invalid watcher slot access in the win32 driver.
...
The underlying file handle and the associated slot could previously be destroyed before the I/O callback had been finally called. Now the callback itself is responsible to destroying the handle.
2018-02-22 01:14:31 +01:00
Sönke Ludwig
c8f95f324b
Enable canceling win32 file I/O.
...
The CancelIOEx call was disabled just due to historical reasons.
2018-02-22 01:12:13 +01:00
Diederik de Groot
41312a589e
Remove static compiler __VERSION check. "import core.sys.dragonflybsd.netinet.in_" will work, when compiler support is there.
...
[See](https://github.com/vibe-d/vibe.d/pull/2028#discussion_r161077152 )
2018-01-11 10:40:37 +01:00
Diederik de Groot
e062e44f1c
Fix compilation on DragonFlyBSD
2018-01-09 15:23:23 +01:00
Sönke Ludwig
6e2938297b
Set O_CLOEXEC on the remaining FDs that are created by eventcore.
2017-12-19 22:10:14 +01:00
Hiroki Noda
214382dcb5
Set EFD_CLOEXEC
...
Add missing one.
2017-12-19 13:38:47 +09:00
Sönke Ludwig
8528b4ec00
Fix accidental resetting of O_NONBLOCK and set O_CLOEXEC on outgoing sockets, too.
2017-12-18 14:07:38 +01:00
Hiroki Noda
1179163150
Add O_CLOEXEC for some posix platform
2017-12-18 09:44:08 +01:00
Hiroki Noda
b252c97012
Set close-on-exec flag to prevent fd leakage for command execution
2017-12-18 09:44:08 +01:00
Sönke Ludwig
c3fa500c3b
Merge pull request #39 from kubo39/epoll-cloexec
...
Set EPOLL_CLOEXEC to prevent fd leakage for command executation
2017-12-16 18:58:40 +01:00
Sönke Ludwig
c45f7dc35e
Properly increment the waiter count during async TCP connect.
2017-12-16 17:55:13 +01:00
Hiroki Noda
277743914b
Set EPOLL_CLOEXEC to prevent fd leakage for command executation
...
This is for the same reason #38
2017-12-16 10:16:43 +09:00
Sönke Ludwig
9ca1a4c3a6
Fix inotify based directory watcher for recursive directory adds.
...
Newly added folders were not scanned recursively, which would result in sub folders that already exist or are added concurrently to not be watched.
2017-12-02 02:54:13 +01:00
Sönke Ludwig
29aee9ee52
Defer driver dispose in main thread to shared static ~this.
...
Allows dependent code to still access the driver from within their shared static ~this. vibe-core notably falls into this category.
2017-11-25 16:59:53 +01:00
Sönke Ludwig
2d4ccf454d
Properly increment waiter count for WinAPI file I/O operations.
2017-11-25 16:47:29 +01:00
Sönke Ludwig
07d2bafcac
Fix threading issues in the generic Posix event implementation.
...
Uses socketpair non-Linux systems and two separate UDP sockets on Windows for the cross-thread communication.
2017-11-25 11:42:19 +01:00
Sönke Ludwig
a5d4cf875c
Add adoptDatagramSocketInternal.
2017-11-25 00:26:44 +01:00
Sönke Ludwig
c8eb30f6f0
Remove polling threads from map.
2017-11-25 00:26:20 +01:00
Sönke Ludwig
31286e4580
Ensure the socket handle passed to callbacks is always valid on Posix.
2017-11-23 23:12:35 +01:00
Sönke Ludwig
4d00376873
Ensure proper reference count for created Posix events.
2017-11-23 23:12:35 +01:00
Sönke Ludwig
19879712e6
Fix shutdown procedure and rename event order for the polling watcher.
...
Renames should always be reported as removed->added instead of added->removed.
2017-11-23 23:11:16 +01:00
Sönke Ludwig
1d4fbc4fa2
Fixup poll driver.
2017-11-23 23:11:16 +01:00
Sönke Ludwig
c8fd340240
Fix destruction of PosixEventDriverEvents event.
...
The reference count was one too high and the waiter count was not properly decremented when an event got destroyed.
2017-11-23 23:11:16 +01:00
Sönke Ludwig
aa9a08f571
Explicitly dispose the event driver on thread shutdown.
...
Handle multiple calls to dispose() gracefully, because external code may already make an explicit call to dispose().
2017-11-23 23:11:16 +01:00
Sönke Ludwig
16e95b03e8
Fix WinAPI watcher to be consistent.
2017-11-22 17:14:31 +01:00
Sönke Ludwig
a9ae496fb4
Avoid "." path in InotifyEventDriverWatchers.
...
The vibe-core tests broke because a "/./" path segment slipped into the resulting paths.
2017-11-22 17:07:49 +01:00
Sönke Ludwig
5246593432
Fix handling recursive inotify based directory watchers.
2017-11-21 10:42:21 +01:00
Sönke Ludwig
0ec498207d
Gag directory modified events in win32.
2017-11-21 10:42:21 +01:00
Sönke Ludwig
99088e1202
Implement a generic polling based directory watcher.
...
This is used on platforms that don't have a specialized watcher implementation.
2017-11-21 10:42:21 +01:00
Sönke Ludwig
815db0727c
Change all invalid handle values to ~0 and improve FileChange.
...
FileChange now has the full path of a file split into the base path (as specified when creating the watcher), the sub directory, and the file name. This allows to work with less dynamic memory allocations internally.
2017-11-21 10:42:14 +01:00
Sönke Ludwig
3352423414
Fix decrementing the waiter count when destroying a WinAPI event with active waiters.
2017-11-21 00:09:41 +01:00
Sönke Ludwig
fdeef38ef4
Fix waiter count tracking for WinAPI directory watchers and avoid empty callbacks.
2017-11-20 15:59:35 +01:00
Sönke Ludwig
314bd2bb48
Fix WinAPI condition for outOfWaiters event loop exit reason.
...
Calling processEvents could previously block indefinitely even if there were no waiters left.
2017-11-20 15:59:35 +01:00
Sönke Ludwig
7cc6bec14a
Fix a possible range error when a win32 file watcher gets destroyed while waiting.
...
This is not a final solution, but avoids the fatal error and replaces it with, at worst, bogus change events being reported.
2017-11-17 18:35:48 +01:00
Sönke Ludwig
0897b1bc9e
Implement WinAPIEventDriverSockets.cancelConnectStream.
2017-11-12 14:41:08 +01:00
Sönke Ludwig
569b75e050
More detailed documentation for cancelConnectStream().
2017-11-12 14:34:58 +01:00
Boris-Barboris
36b0413d32
remove cabblack invocation
2017-11-11 15:44:13 +00:00
Boris-Barboris
0cac9d56e0
cancelConnectStream for Posix
2017-11-11 01:14:54 +00:00
Sönke Ludwig
c4550f0e59
Fix ThreadedFileEventDriver read/write issues.
...
I/O errors were being reported as IOStatus.ok instead of IOStatus.error, and the I/O operation finalization protocol had a potential race-condition when storing the number of bytes processed.
2017-10-30 22:54:14 +01:00
Sönke Ludwig
8799b7b01e
Add assertion.
2017-09-26 15:49:13 +02:00