Commit graph

334 commits

Author SHA1 Message Date
Sönke Ludwig 3d2a2656bb Robustness fix for WinAPIEventDriverWatchers.
Under certain (rare) circumstances, the receive buffer contains data from a file instead of the expected FILE_NOTIFY_INFORMATION structure. No signs of handle or buffer reuse could be found, so the cause for this remains unclear. Until the cause can be narrowed down, this keeps the issue visible while avoiding to crash the application.
2018-03-03 20:04:51 +01:00
Sönke Ludwig fbd6927377 Improve robustness of file I/O callbacks for the WinAPI driver.
Explicitly gets the read/write slot from the handle map from within the callback instead of dereferencing the pointer assigned when starting the operation. This makes sure that no dangling reference is accessed. Instead, if the slot got reused before the callback is invoked (which is a bug), an assertion will be triggered if the slot now has a different handle type.
2018-03-03 19:56:54 +01:00
Sönke Ludwig 3a52e0f362 Fix cast from HANDLE to descriptor in the WinAPI driver.
Avoids truncation to 32-bit for 64-bit builds. Also improves robustness of the directory watcher shutdown procedure.
2018-03-03 19:56:54 +01:00
Sönke Ludwig 79226e2c60
Merge pull request #52 from vibe-d/update_compiler_support
Update compiler support.
2018-03-03 19:55:06 +01:00
Sönke Ludwig 2fc7132829 Exclude LDC 1.4.0/macOS. 2018-03-03 19:50:57 +01:00
Sönke Ludwig 944ebf5ea9 Adjust for changed LDC download URLs. 2018-03-03 19:34:27 +01:00
Sönke Ludwig 27a80b6e0a Add DMD 2.079.0 support. 2018-03-03 18:40:36 +01:00
Sönke Ludwig 446e96fff3 Ignore DMD 2.072.2 build errors caused by old DUB version. 2018-03-03 18:19:56 +01:00
Sönke Ludwig 4bcf113732 Update compiler support.
Drops 2.071.2 and adds 2.078.3.
2018-03-03 18:02:26 +01:00
Sönke Ludwig e8e8f85271 Add DatagramSocket.broadcast property. Fixes #47. 2018-02-22 02:08:09 +01:00
Sönke Ludwig b2b072dd80 Reduce the number of ChoppedVector index operations. 2018-02-22 01:58:49 +01:00
Sönke Ludwig 30f614a7ff
Merge pull request #50 from vibe-d/fix_watcher_cancellation
Fix watcher cancellation
2018-02-22 01:56:13 +01:00
Sönke Ludwig e9df91f450
Merge pull request #48 from dkgroot-dlang/master
Fix compilation on DragonFlyBSD
2018-02-22 01:56:04 +01:00
Sönke Ludwig 0e7091d085 Fix invalid watcher slot access in the win32 driver.
The underlying file handle and the associated slot could previously be destroyed before the I/O callback had been finally called. Now the callback itself is responsible to destroying the handle.
2018-02-22 01:14:31 +01:00
Sönke Ludwig c8f95f324b Enable canceling win32 file I/O.
The CancelIOEx call was disabled just due to historical reasons.
2018-02-22 01:12:13 +01:00
Diederik de Groot 41312a589e
Remove static compiler __VERSION check. "import core.sys.dragonflybsd.netinet.in_" will work, when compiler support is there.
[See](https://github.com/vibe-d/vibe.d/pull/2028#discussion_r161077152)
2018-01-11 10:40:37 +01:00
Diederik de Groot e062e44f1c
Fix compilation on DragonFlyBSD 2018-01-09 15:23:23 +01:00
Sönke Ludwig 97b154048d
Merge pull request #46 from vibe-d/more_cloexec
Set O_CLOEXEC on the remaining FDs that are created by eventcore.
2017-12-20 01:55:14 +01:00
Sönke Ludwig 6e2938297b Set O_CLOEXEC on the remaining FDs that are created by eventcore. 2017-12-19 22:10:14 +01:00
Sönke Ludwig 324338205b
Merge pull request #45 from kubo39/efd-cloexec
Set EFD_CLOEXEC
2017-12-19 10:45:11 +01:00
Hiroki Noda 214382dcb5 Set EFD_CLOEXEC
Add missing one.
2017-12-19 13:38:47 +09:00
The Dlang Bot 94028e56dd
Merge pull request #44 from vibe-d/cloexec
Set O_CLOEXEC on socket descriptors
merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com>
2017-12-18 17:35:18 +01:00
Sönke Ludwig 8528b4ec00 Fix accidental resetting of O_NONBLOCK and set O_CLOEXEC on outgoing sockets, too. 2017-12-18 14:07:38 +01:00
Sönke Ludwig 50fe0b28b5 Add watchdog timer and log output to flaky test. 2017-12-18 14:06:58 +01:00
Hiroki Noda 1179163150 Add O_CLOEXEC for some posix platform 2017-12-18 09:44:08 +01:00
Hiroki Noda b252c97012 Set close-on-exec flag to prevent fd leakage for command execution 2017-12-18 09:44:08 +01:00
The Dlang Bot 107f4c084f
Merge pull request #43 from vibe-d/test_latest_compilers
Test the latest compiler versions.
merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com>
2017-12-18 01:13:46 +01:00
Sönke Ludwig 93f92dccf8 Support LDC/GDC for the win32 configuration. 2017-12-17 22:42:36 +01:00
Sönke Ludwig 7ea0e34a46 Further increase the timer test tolerance to account for the macOS builds. 2017-12-17 22:17:40 +01:00
Sönke Ludwig 9a580ccbf9 Test the latest compiler versions. 2017-12-17 22:17:40 +01:00
Sönke Ludwig 2005c93f53 Display the timeout different in timer assertions. 2017-12-17 12:05:58 +01:00
Sönke Ludwig c3fa500c3b
Merge pull request #39 from kubo39/epoll-cloexec
Set EPOLL_CLOEXEC to prevent fd leakage for command executation
2017-12-16 18:58:40 +01:00
Sönke Ludwig 2c6b69590d Relax timer test constraints and don't gag assertions.
Attempts to fix the flaky tests on macOS.
2017-12-16 18:53:58 +01:00
Sönke Ludwig 135217066f
Merge pull request #41 from vibe-d/fix_winapi_connect_waitercount
Properly increment the waiter count during async TCP connect.
2017-12-16 18:25:14 +01:00
Sönke Ludwig c45f7dc35e Properly increment the waiter count during async TCP connect. 2017-12-16 17:55:13 +01:00
Hiroki Noda 277743914b Set EPOLL_CLOEXEC to prevent fd leakage for command executation
This is for the same reason #38
2017-12-16 10:16:43 +09:00
Sönke Ludwig 979640b074 Increase the tolerance for the second timer test, too. 2017-12-02 13:47:36 +01:00
Sönke Ludwig 929164e114 Increase timer tolerance in test to avoid macOS failures. 2017-12-02 13:16:30 +01:00
Sönke Ludwig 65b9b71cf8
Merge pull request #36 from vibe-d/fix_inotify_rec_watcher
Fix inotify based directory watcher for recursive directory adds.
2017-12-02 13:15:53 +01:00
Sönke Ludwig 9ca1a4c3a6 Fix inotify based directory watcher for recursive directory adds.
Newly added folders were not scanned recursively, which would result in sub folders that already exist or are added concurrently to not be watched.
2017-12-02 02:54:13 +01:00
Sönke Ludwig 29aee9ee52 Defer driver dispose in main thread to shared static ~this.
Allows dependent code to still access the driver from within their shared static ~this. vibe-core notably falls into this category.
2017-11-25 16:59:53 +01:00
Sönke Ludwig 2d4ccf454d Properly increment waiter count for WinAPI file I/O operations. 2017-11-25 16:47:29 +01:00
The Dlang Bot 2e3f145f0f
Merge pull request #35 from vibe-d/avoid_dot_in_watcher_path
Fix more directory watcher issues, especially on macOS
merged-on-behalf-of: l-kramer <l-kramer@users.noreply.github.com>
2017-11-25 13:12:17 +01:00
Sönke Ludwig a7c5aea124 Reformat the driver status table to be more compact. 2017-11-25 11:54:18 +01:00
Sönke Ludwig 07d2bafcac Fix threading issues in the generic Posix event implementation.
Uses socketpair non-Linux systems and two separate UDP sockets on Windows for the cross-thread communication.
2017-11-25 11:42:19 +01:00
Sönke Ludwig a5d4cf875c Add adoptDatagramSocketInternal. 2017-11-25 00:26:44 +01:00
Sönke Ludwig c8eb30f6f0 Remove polling threads from map. 2017-11-25 00:26:20 +01:00
Sönke Ludwig 31286e4580 Ensure the socket handle passed to callbacks is always valid on Posix. 2017-11-23 23:12:35 +01:00
Sönke Ludwig 4d00376873 Ensure proper reference count for created Posix events. 2017-11-23 23:12:35 +01:00
Sönke Ludwig 7795195ec1 Fix recursive directory watcher test to check for unexpected events. 2017-11-23 23:11:16 +01:00