debian-packages/vibe-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix a race-condition in TaskPool.

Browse source 
The lock that should surround the foreach loop was given up prematurely.
This commit is contained in:
Sönke Ludwig 2018-03-07 10:39:28 +01:00
parent eb046e2295
commit 7703cc675f
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
source/vibe/core/taskpool.d
View file

@ -220,9 +220,12 @@ shared final class TaskPool {
static assert(areConvertibleTo!(Group!ARGS, Group!FARGS), static assert(areConvertibleTo!(Group!ARGS, Group!FARGS),
"Cannot convert arguments '"~ARGS.stringof~"' to function arguments '"~FARGS.stringof~"'."); "Cannot convert arguments '"~ARGS.stringof~"' to function arguments '"~FARGS.stringof~"'.");
foreach (thr; m_state.lock.threads) { {
// create one TFI per thread to properly account for elaborate assignment operators/postblit auto st = m_state.lock;
thr.m_queue.put(callable, args); foreach (thr; st.threads) {
// create one TFI per thread to properly account for elaborate assignment operators/postblit
thr.m_queue.put(callable, args);
}
} }
m_signal.emit(); m_signal.emit();
} }