debian-packages/vibe-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix integer overflow protection absence for LocalManualEvent

Browse source
This commit is contained in:
Boris-Barboris 2018-03-30 09:11:30 +00:00
parent ff93b0de81
commit a840c51c5d
1 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
source/vibe/core/sync.d
View file

@ -778,7 +778,7 @@ struct LocalManualEvent {
target_timeout = now + timeout; target_timeout = now + timeout;
} }
while (m_waiter.m_emitCount <= emit_count) { while (m_waiter.m_emitCount - emit_count > 0) {
m_waiter.wait!interruptible(timeout != Duration.max ? target_timeout - now : Duration.max); m_waiter.wait!interruptible(timeout != Duration.max ? target_timeout - now : Duration.max);
try now = Clock.currTime(UTC()); try now = Clock.currTime(UTC());
catch (Exception e) { assert(false, e.msg); } catch (Exception e) { assert(false, e.msg); }
@ -805,6 +805,22 @@ unittest {
runEventLoop(); runEventLoop();
} }
unittest {
import vibe.core.core : exitEventLoop, runEventLoop, runTask, sleep;
auto e = createManualEvent();
// integer overflow test
e.m_waiter.m_emitCount = int.max;
auto w1 = runTask({ e.wait(50.msecs, e.emitCount); });
runTask({
sleep(5.msecs);
e.emit();
sleep(50.msecs);
assert(!w1.running);
exitEventLoop();
});
runEventLoop();
}
unittest { // ensure that cancelled waiters are properly handled and that a FIFO order is implemented unittest { // ensure that cancelled waiters are properly handled and that a FIFO order is implemented
import vibe.core.core : exitEventLoop, runEventLoop, runTask, sleep; import vibe.core.core : exitEventLoop, runEventLoop, runTask, sleep;