debian-packages/vibe-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix a worker task scheduling issue for busy worker tasks.

Browse source 
Fixes new tasks being able to be scheduled on a worker thread while a busy task (that periodically calls yield()) is running.
This commit is contained in:
Sönke Ludwig 2020-12-15 19:43:20 +01:00
parent 0bd78a1a95
commit ade765d6bd
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
source/vibe/core/taskpool.d
View file

@ -346,7 +346,16 @@ private final class WorkerThread : Thread {
try { try {
if (m_pool.m_state.lock.term) return; if (m_pool.m_state.lock.term) return;
logDebug("entering worker thread"); logDebug("entering worker thread");
handleWorkerTasks();
// There is an issue where a task that periodically calls yield()
// but otherwise only performs a CPU computation will cause a
// call to runEventLoopOnce() or yield() called from the global
// thread context to not return before the task is finished. For
// this reason we start a task here, which in turn is scheduled
// properly together with such a task, and also is schduled
// according to the task priorities.
runTask(&handleWorkerTasks).joinUninterruptible();
logDebug("Worker thread exit."); logDebug("Worker thread exit.");
} catch (Throwable th) { } catch (Throwable th) {
th.logException!(LogLevel.fatal)("Worker thread terminated due to uncaught error"); th.logException!(LogLevel.fatal)("Worker thread terminated due to uncaught error");